Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing gc_type tag for gc.pause.by.type metrics #680

Closed
jfirebaugh opened this issue Sep 16, 2019 · 0 comments · Fixed by #681
Closed

Missing gc_type tag for gc.pause.by.type metrics #680

jfirebaugh opened this issue Sep 16, 2019 · 0 comments · Fixed by #681
Labels
bug Something isn't working community core
Milestone

Comments

@jfirebaugh
Copy link

jfirebaugh commented Sep 16, 2019

The runtime.node.gc.pause.by.type.* metrics are intended to include a gc_type tag:

histogram('gc.pause.by.type', stats.gc[type], { gc_type: type })

However, the histogram function ignores the third parameter, so post-aggregation, these metrics aren't really meaningful:

function histogram (name, stats) {
client.gauge(`${name}.min`, stats.min)
client.gauge(`${name}.max`, stats.max)
client.increment(`${name}.sum`, stats.sum)
client.gauge(`${name}.avg`, stats.avg)
client.increment(`${name}.count`, stats.count)
client.gauge(`${name}.median`, stats.median)
client.gauge(`${name}.95percentile`, stats.p95)
}

@jfirebaugh jfirebaugh added the bug Something isn't working label Sep 16, 2019
@rochdev rochdev added this to the 0.15.1 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants