add a noop span around logging #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengl
force-pushed
the
bengl/noop-around-logging
branch
from
e444c22
to
0c68b41
Compare
bengl
changed the title
bengl
force-pushed
the
bengl/noop-around-logging
branch
from
0c68b41
to
28483c2
Compare
rochdev
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Does all internal logging within a NoopSpan, preventing instrumentation of
anything logging related.
Motivation
In debug mode, when logging spans/traces, it's possible to use a logger that
calls instrumented code. This can result in infinite recursions or otherwise
loopy code flow. Surrounding the call with a NoopSpan prevents creating new
spans for logging.