update agent exporter to always use 0.4 endpoint by default #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
added
bug
bengl
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update agent exporter to always use 0.4 endpoint by default.
Motivation
The current logic to detect the agent protocol version at the tracer initialization can cause the tracer to stop reporting traces completely if the version of the agent changes at runtime. It also relies on failures to detect the protocol version and is unable to determine the version without trying all of them in sequence. This is made even worse with load-balanced agents on a separate cluster which may use multiple versions at the same time.
We will revisit detecting this automatically when we have a better design, and in the meantime the version will need to be updated manually as needed on a case by case basis.