Span Creation Optimizations #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a `filter` loop was run over the `references` array _prior_ to iterating through and finding the parent. This has now been combined into a single loop, also avoiding closure creation. On my machine, this creates a measurable performance benefit on `yarn bench:e2e`. Before: ``` $ yarn bench:e2e -- --duration=300 # 5 min each, w/ tracer & control avg latency overhead % 47.97297297297296 avg requests overhead % 43.17721241906214 avg throughput overhead % 43.15483642890816 ``` After: ``` $ yarn bench:e2e -- --duration=300 # 5 min each, w/ tracer & control avg latency overhead % 41.163793103448285 avg requests overhead % 37.218656879389656 avg throughput overhead % 37.20555614151182 ```
bengl
force-pushed
the
bengl/span-creation-optimizations
branch
from
2f56951
to
354ac45
Compare
rochdev
requested changes
Oct 7, 2020
bengl
force-pushed
the
bengl/span-creation-optimizations
branch
from
354ac45
to
1527e92
Compare
This avoids all the logic in `getParent` iterating through a list of references to find the parent, specifically in the case where there are no references (i.e. the user is not specifically using opentracing). This change did not create any noticeable difference in benchmarks, likely due to the previous change having already cut out the majority of the overhead in this code path.
bengl
force-pushed
the
bengl/span-creation-optimizations
branch
from
1527e92
to
fa4c023
Compare
rochdev
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See commit message of first commit for performance difference
Motivation
Better Performance