Add KafkaJS support #1146
Merged
Add KafkaJS support #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theweb/dd-trace-js into puzzledbytheweb/kafkajs-plugin
…theweb/dd-trace-js into puzzledbytheweb/kafkajs-plugin
rochdev
reviewed
Nov 30, 2020
rochdev
reviewed
Dec 17, 2020
rochdev
reviewed
Dec 17, 2020
bengl
approved these changes
Jan 5, 2021
bengl
requested changes
Jan 5, 2021
| currentSpan.addTags({ | ||
| 'resource.name': topic, | ||
| 'kafka.topic': topic, | ||
| 'kafka.batch.size': messages.length |
There was a problem hiding this comment.
@rochdev should this be changed before merge?
|
I did it this way erroneously, it should be |
rochdev
approved these changes
Jan 5, 2021
bengl
approved these changes
Jan 6, 2021
Czechh
added a commit
that referenced
this pull request
Jan 11, 2021
* master: fix ts for aws split-by-service change (#1201) [ci-app] Better Test Name in Jest Instrumentation (#1190) v0.30.0 (#1198) add type definitions for aws-sdk service configuration (#1197) add option to enable/disable tracing of individual aws services (#1193) replace blacklist and whitelist with blocklist and allowlist (#1196) add container tagging support for ecs docker id (#1176) add option to split ioredis service name by instance (#1194) Call options fn on each invocation in tracer.wrap (#1191) export the tracer from implicit init file (#1192) fix double-routing in restify (#1161) [CIAPP-474] Mocha support (#1162) Add KafkaJS support (#1146) Revert "wrap end on prototype instead of instances (#1127)" (#1189) fix missing span types in some web and worker plugins (#1178) [ci-app] Fix Jest Flaky Test Setup and Use More Supported Branch Extraction (#1188)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds KafkaJS support in this package, using their own instrumentation events.
Motivation
Using DD-trace in my work we were a bit disappointed that there was no out-of-the-box support for KafkaJS.
Plugin Checklist
Additional Notes
I think I'll need some help with not only the the usual "make this work" stuff but also with the unit tests and what do we care testing.
Cheers!