fix graphql plugin error when using sampling #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
approved these changes
Nov 27, 2020
|
wow, the time to fix here is amazing! 🙌 |
keepitterron
approved these changes
Nov 27, 2020
|
Yep! really appreciate the quick fix here folks 🙌 🚀 |
rochdev
added a commit
that referenced
this pull request
Nov 27, 2020
Czechh
added a commit
that referenced
this pull request
Dec 1, 2020
…rada/add-trace-to-lambda-invoke * 'master' of github.com:DataDog/dd-trace-js: fix graphql plugin error when using sampling (#1164) v0.29.0 (#1160) fix mongodb integration not instrumenting correctly (#1159) clean up test scripts (#1158) fix consumer span not waiting for message ack before finishing (#1152) provide a way to know when flush is finished (#1154) add experimental option to mark internal spans on errors (#1153) Remove only from it, probably left in by accident (#1149) add support for @grpc/grpc-js (#1147) remove idle call frame samples from profiles (#1143) fix socket connect callback not running in parent scope (#1142) add a fast path in toArray for length-8 IDs (#1138) Fix GraphQL span finishTime calculation (#1139) v0.28.0 (#1137) skip browser test for setUrl (#1135) fix ingestion rate limiter drifting on interval change (#1132)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix GraphQL plugin error when using sampling. For now this is fixed in the plugin directly, but eventually a cleaner way to do handle this should be implemented.
Motivation
The no-op implementation of
Spandoesn't have the_getTimeprivate method which is used by the GraphQL plugin. Ideally this method should not be needed since it's private, but the way the GraphQL plugin works means it needs to be able to store the finish time when resolving arrays.Fixes #1163