fix bound emitters leaking when trying to remove all listeners #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1260 +/- ##
==========================================
+ Coverage 92.50% 92.59% +0.08%
==========================================
Files 149 149
Lines 6074 6074
==========================================
+ Hits 5619 5624 +5
+ Misses 455 450 -5
Continue to review full report at Codecov.
|
bengl
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix bound emitters leaking when trying to remove all listeners.
Motivation
The latest version of Axios bumped the version of their
follow-redirectsdependency which includes follow-redirects/follow-redirects@ad15f9b which relies on removing all event listeners from the underlying request. This caused the tracer to start crashing when used with Axios because the scope manager didn't properly handle calls toremoveAllListenerswithout an actual event name, so all listeners were still attached to the emitter.Fixes #1253