[serverless] add support for datadog extension #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
reviewed
Mar 11, 2021
Yes, it runs in the same sandbox. |
rochdev
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for submitting traces via the Datadog Lambda Extension. The Datadog Lambda Extension is a special flavor of the datadog agent, the hooks into the AWS Lambda runtime. Read the draft RFC on tracing with the extension here for more context.
We also change the detection mechanism for the log exporter, only selecting it when we detect a serverless environment AND the extension isn't present. We use a hardcoded file system path to detect the extension, (due to the way the extension API works, the extension can only be at that path). When in serverless mode, we also modify the agent exporter so it flushes it immediately.
Motivation
To supporting tracing via the Datadog Extension automatically
Additional Notes