fix requests to the agent being traced #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengl
reviewed
Apr 9, 2021
| @@ -22,7 +22,7 @@ module.exports = { | |||
| agent = express() | |||
| agent.use(bodyParser.raw({ limit: Infinity, type: 'application/msgpack' })) | |||
| agent.use((req, res, next) => { | |||
| if (req.body.length === 0) return res.status(200).send() | |||
| if (!req.body.length) return res.status(200).send() | |||
There was a problem hiding this comment.
bodyParser defaults to an empty object when the content type didn't match, which doesn't have a length property.
Codecov Report
@@ Coverage Diff @@
## master #1299 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 150 150
Lines 6113 6113
=======================================
Hits 5659 5659
Misses 454 454
Continue to review full report at Codecov.
|
bengl
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix requests to the agent being traced.
Motivation
Fix #1248