fix tedious invalid stored procedure tag #1508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
tedious
invalid stored procedure tag. Additionally, fix race conditions in tests that would result in random failures when the connection is closed before the request is finished, which happens more often with the latest version.Motivation
The tag was originally added to capture the stored procedure name, but the internals of the library were changed in a way where we can no longer capture
sp_*
stored procedures, and other stored procedures can have any name so we can't differentiate them, meaning the tag actually doesn't capture what it's supposed to capture. Removing the tag is thus the only solution here since it doesn't work as advised.