Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tedious invalid stored procedure tag #1508

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jul 16, 2021

What does this PR do?

Fix tedious invalid stored procedure tag. Additionally, fix race conditions in tests that would result in random failures when the connection is closed before the request is finished, which happens more often with the latest version.

Motivation

The tag was originally added to capture the stored procedure name, but the internals of the library were changed in a way where we can no longer capture sp_* stored procedures, and other stored procedures can have any name so we can't differentiate them, meaning the tag actually doesn't capture what it's supposed to capture. Removing the tag is thus the only solution here since it doesn't work as advised.

@rochdev rochdev added bug Something isn't working dev/testing integrations labels Jul 16, 2021
@rochdev rochdev added this to the 1.0.1 milestone Jul 16, 2021
@rochdev rochdev requested a review from a team as a code owner July 16, 2021 18:26
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1508 (4e1f8d4) into master (8bf9111) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
+ Coverage   94.16%   94.17%   +0.01%     
==========================================
  Files         157      157              
  Lines        6391     6403      +12     
==========================================
+ Hits         6018     6030      +12     
  Misses        373      373              
Impacted Files Coverage Δ
packages/datadog-plugin-tedious/src/index.js 100.00% <ø> (ø)
packages/datadog-plugin-cucumber/src/index.js 96.92% <100.00%> (-0.05%) ⬇️
...ackages/datadog-plugin-mongodb-core/src/unified.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be3b61...4e1f8d4. Read the comment docs.

@rochdev rochdev merged commit 4f248ef into master Jul 16, 2021
@rochdev rochdev deleted the fix-tedious-invalid-proc-name branch July 16, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants