Make profiler use form-data as stream #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
force-pushed
the
profiler-export-streaming
branch
from
683968a
to
521222c
Compare
rochdev
approved these changes
Oct 14, 2021
|
Is there a benchmark where we can see the improvement? |
|
Not handy, no. I discovered it in a bunch of testing of native pprof encoding, but it's mixed with a bunch of other data. |
rochdev
pushed a commit
that referenced
this pull request
Nov 2, 2021
rochdev
pushed a commit
that referenced
this pull request
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve export performance. Turns out concatenating larger buffers is more expensive than streamed writes.