Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix express wrong resource name and missing error field #166

Merged
merged 4 commits into from Jun 29, 2018
Merged

fix express wrong resource name and missing error field #166

merged 4 commits into from Jun 29, 2018

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jun 28, 2018

This PR fixes the following 2 issues with the express integration:

  • The resource name would fallback to the operation name in some cases. It now fallbacks to the HTTP verb making it more intuitive and consistent with other integrations.
  • The error field was not set on error.

Additionally, a configuration option was added to use a custom validator for the status code to determine if it should be an error.

@rochdev rochdev added bug Something isn't working integrations labels Jun 28, 2018
@rochdev rochdev added this to the 0.3.2 milestone Jun 28, 2018
@rochdev rochdev merged commit 3320fa5 into master Jun 29, 2018
@rochdev rochdev deleted the fix-express-resource branch June 29, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinvol vinvol vinvol approved these changes

Assignees
No one assigned
Labels
bug Something isn't working integrations
Projects
None yet
Milestone
0.3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rochdev @vinvol