fix grpc client instrumentation when service prop exists #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengl
force-pushed
the
bengl/fixgrpcserviceprop
branch
from
4acc4a7
to
8f9b662
Compare
rochdev
approved these changes
Oct 26, 2021
rochdev
pushed a commit
that referenced
this pull request
Nov 2, 2021
rochdev
pushed a commit
that referenced
this pull request
Nov 2, 2021
bengl
added a commit
that referenced
this pull request
Jun 2, 2022
bengl
added a commit
that referenced
this pull request
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1659
Previously, this bit of code was incorrectly assuming every
.serviceproperty was a constructor. That assumption was causing an exception to be thrown at startup.