set db span types to sql #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiehodge
force-pushed
the
jhodge-sql-type
branch
from
efb01c1
to
85a0d59
Compare
jamiehodge
force-pushed
the
jhodge-sql-type
branch
from
85a0d59
to
d595d69
Compare
rochdev
approved these changes
Jul 3, 2018
|
Sorry about the tests. The integration tests are a bit flaky at the moment because of the way the mock agent is setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL integrations are not currently quantizing their resources because the span type is set to
dbwhen it should besql.The tests are failing for apparently unrelated plugins.