fix http client integration always setting the error flag #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengl
approved these changes
Apr 4, 2022
rochdev
added a commit
that referenced
this pull request
Apr 4, 2022
rochdev
added a commit
that referenced
this pull request
Apr 4, 2022
|
Still seeing something similar for HEAD requests in spans (all are marked as errors, even though they did not encounter errors). Would this fix that? EDIT: opened an issue #2089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
httpclient integration always setting the error flag.Motivation
The
async-endevent was published multiple times, which resulted in the error flag being updated by theclosehandler which normally means there was an error when no other event was received first.Fixes #1953