Use 99hz as default profiling sample rate #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
force-pushed
the
non-power-of-ten-profiling-sample-rate
branch
from
f209ac4
to
ea33e7d
Compare
rochdev
previously approved these changes
Apr 25, 2022
Qard
force-pushed
the
non-power-of-ten-profiling-sample-rate
branch
from
ea33e7d
to
33f9de2
Compare
|
Force pushed to re-run the CI. Hopefully npm is in a better state this time... |
Qard
force-pushed
the
non-power-of-ten-profiling-sample-rate
branch
from
33f9de2
to
e2188a8
Compare
rochdev
approved these changes
Apr 26, 2022
simon-id
pushed a commit
that referenced
this pull request
Apr 27, 2022
simon-id
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid power of ten sample rates. This is to avoid bias toward things like timers which are often defined at power of ten intervals. Probably won't actually make much difference with Node.js because timers are best-effort timing through the event loop, but there's no reason not to do this. 馃し馃徎