Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 403 error from AWS when sending a signed request #205

Merged
merged 1 commit into from Jul 30, 2018
Merged

fix 403 error from AWS when sending a signed request #205

merged 1 commit into from Jul 30, 2018

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jul 30, 2018

This PR fixes 403 errors from AWS when sending signed requests.

AWS uses the headers when signing, and since we are altering the headers when injecting the span context, the signature would become invalid. This is unnecessary for requests to AWS since it cannot propagate context, so this PR removes the injection for these requests.

@rochdev rochdev added bug Something isn't working integrations labels Jul 30, 2018
@rochdev rochdev added this to the 0.5.3 milestone Jul 30, 2018
@rochdev rochdev merged commit 4dc670f into master Jul 30, 2018
@rochdev rochdev deleted the fix-aws-signature branch July 30, 2018 18:29
@mooyoul mooyoul mentioned this pull request Jun 19, 2022
Open
@ryan-breidenbach ryan-breidenbach mentioned this pull request Oct 13, 2023
Closed
@tlhunter tlhunter mentioned this pull request Nov 14, 2023
Merged
8 tasks
tlhunter added a commit that referenced this pull request Nov 15, 2023
@tlhunter
enable tracing header injection for AWS requests (#3796)
03abcfa 
- removes the code that disabled tracing headers when amazon signature headers were present
- essentially reverts #205
- was originally done to prevent breaking AWS signatures
- apparently the presence of our headers does not break amazon signatures after all
- fixes #3719
tlhunter added a commit that referenced this pull request Nov 15, 2023
@tlhunter
enable tracing header injection for AWS requests (#3796)
0f2b218 
- removes the code that disabled tracing headers when amazon signature headers were present
- essentially reverts #205
- was originally done to prevent breaking AWS signatures
- apparently the presence of our headers does not break amazon signatures after all
- fixes #3719
pull bot pushed a commit to astradot/dd-trace-js that referenced this pull request Nov 15, 2023
@tlhunter
enable tracing header injection for AWS requests (DataDog#3796)
14c1eb0 
- removes the code that disabled tracing headers when amazon signature headers were present
- essentially reverts DataDog#205
- was originally done to prevent breaking AWS signatures
- apparently the presence of our headers does not break amazon signatures after all
- fixes DataDog#3719
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
@tlhunter @khanayan123
enable tracing header injection for AWS requests (#3796)
f2ebb3e 
- removes the code that disabled tracing headers when amazon signature headers were present
- essentially reverts #205
- was originally done to prevent breaking AWS signatures
- apparently the presence of our headers does not break amazon signatures after all
- fixes #3719
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
@tlhunter @khanayan123
enable tracing header injection for AWS requests (#3796)
014906b 
- removes the code that disabled tracing headers when amazon signature headers were present
- essentially reverts #205
- was originally done to prevent breaking AWS signatures
- apparently the presence of our headers does not break amazon signatures after all
- fixes #3719
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
@tlhunter @khanayan123
enable tracing header injection for AWS requests (#3796)
63653f0 
- removes the code that disabled tracing headers when amazon signature headers were present
- essentially reverts #205
- was originally done to prevent breaking AWS signatures
- apparently the presence of our headers does not break amazon signatures after all
- fixes #3719
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
@tlhunter @khanayan123
enable tracing header injection for AWS requests (#3796)
1bbe9da 
- removes the code that disabled tracing headers when amazon signature headers were present
- essentially reverts #205
- was originally done to prevent breaking AWS signatures
- apparently the presence of our headers does not break amazon signatures after all
- fixes #3719
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
@tlhunter @khanayan123
enable tracing header injection for AWS requests (#3796)
266b966 
- removes the code that disabled tracing headers when amazon signature headers were present
- essentially reverts #205
- was originally done to prevent breaking AWS signatures
- apparently the presence of our headers does not break amazon signatures after all
- fixes #3719
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
@tlhunter @khanayan123
enable tracing header injection for AWS requests (#3796)
a6d48ca 
- removes the code that disabled tracing headers when amazon signature headers were present
- essentially reverts #205
- was originally done to prevent breaking AWS signatures
- apparently the presence of our headers does not break amazon signatures after all
- fixes #3719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinvol vinvol vinvol approved these changes

Assignees
No one assigned
Labels
bug Something isn't working integrations
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rochdev @vinvol