Support passing in a function to determine service name for mysql #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
reviewed
May 19, 2022
rochdev
added
enhancement
nampas
reviewed
May 20, 2022
rochdev
requested changes
May 20, 2022
rochdev
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Similar to the existing behavior of the
OracleDBpackage and others - this PR adds support for passing in a function to dynamically setservicefor themysqlandmysql2packages.Motivation
We have a service that queries multiple databases owned by other services (has to do with outbox event propagation). Let's call this service "something-api". Currently the spans encompassing queries from "something-api" to ANY database is "something-api-mysql". To ease debugging, we'd like to have a unique name per DB-instance we're querying. We could achieve this on our end if service was definable via a function we pass in.
Plugin Checklist
Additional Notes