Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report user agent in traces #2074

Merged
merged 7 commits into from
May 29, 2022
Merged

Report user agent in traces #2074

merged 7 commits into from
May 29, 2022

Conversation

simon-id
Copy link
Member

What does this PR do?

This adds the http.useragent tag, that is reported on every http request.

Motivation

This follow the tag unification initiative, and it will provide value for "AppSec Light" which runs the WAF in the backend without the need to enable AppSec in the tracer.

@simon-id simon-id self-assigned this May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #2074 (b9c2d1c) into master (edc3406) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
- Coverage   92.89%   92.81%   -0.09%     
==========================================
  Files         207      207              
  Lines        8264     8293      +29     
==========================================
+ Hits         7677     7697      +20     
- Misses        587      596       +9     
Impacted Files Coverage Δ
packages/datadog-plugin-http2/src/server.js 25.45% <100.00%> (+0.68%) ⬆️
packages/dd-trace/src/plugins/util/web.js 90.12% <100.00%> (+0.04%) ⬆️
packages/datadog-plugin-amqplib/src/index.js
packages/datadog-instrumentations/src/amqplib.js
packages/datadog-plugin-kafkajs/src/index.js 97.14% <0.00%> (ø)
packages/datadog-instrumentations/src/kafkajs.js 87.09% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@simon-id simon-id marked this pull request as ready for review May 25, 2022 11:49
@simon-id simon-id requested a review from a team as a code owner May 25, 2022 11:49
Copy link
Collaborator

@bengl bengl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @rochdev you should review since it touches web stuff in new plugin system.

@simon-id simon-id merged commit 7532461 into master May 29, 2022
simon-id added a commit that referenced this pull request Jun 8, 2022
* add tag name constant

* typings

* report user agent

* http2 support

* add tests
rochdev pushed a commit that referenced this pull request Jun 8, 2022
* add tag name constant

* typings

* report user agent

* http2 support

* add tests
@simon-id simon-id deleted the add_useragent_tag branch January 8, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants