-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report user agent in traces #2074
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
==========================================
- Coverage 92.89% 92.81% -0.09%
==========================================
Files 207 207
Lines 8264 8293 +29
==========================================
+ Hits 7677 7697 +20
- Misses 587 596 +9
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @rochdev you should review since it touches web stuff in new plugin system.
* add tag name constant * typings * report user agent * http2 support * add tests
* add tag name constant * typings * report user agent * http2 support * add tests
What does this PR do?
This adds the
http.useragent
tag, that is reported on every http request.Motivation
This follow the tag unification initiative, and it will provide value for "AppSec Light" which runs the WAF in the backend without the need to enable AppSec in the tracer.