fix koa middleware overwriting route of actual router #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2095 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 207 207
Lines 8231 8233 +2
=======================================
+ Hits 7641 7643 +2
Misses 590 590
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bengl
approved these changes
Jun 1, 2022
simon-id
pushed a commit
that referenced
this pull request
Jun 8, 2022
rochdev
added a commit
that referenced
this pull request
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix koa middleware overwriting route of actual router.
Motivation
Middleware were setting the route in the order that
nextwas called instead of the order in which they were entered, resulting in incorrect routes or paths in reverse order.Fixes #2092