fix aws-sdk complete event running in wrong async context #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2099 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 206 206
Lines 8303 8304 +1
=======================================
+ Hits 7705 7706 +1
Misses 598 598
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bengl
approved these changes
Jun 2, 2022
rochdev
changed the title
simon-id
pushed a commit
that referenced
this pull request
Jun 8, 2022
rochdev
added a commit
that referenced
this pull request
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix aws-sdk complete event running in wrong async context.
Motivation
Running the event in the wrong context means that sometimes it receives the HTTP span and never finishes the AWS span, thus never finishing the trace.