fix memory leak in http plugin when sockets are reused #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak in the
http
plugin when sockets are reused for multiple requests, for example when settingkeepAlive
to true. Since an event handler was attached to the socket directly and never removed for every request, they would slowly add up for the life of the socket.The fix also has the additional benefit that the span will no longer finish early if the connection is closed before all data has been consumed.
Fixes #206