tracking open spans

[tlhunter]

What does this PR do?

• adds metrics for spans that are truly unfinished

Motivation

• a customer is having an issue with span correlations and this should help track it down

Plugin Checklist

• Unit tests.
• TypeScript definitions.
• TypeScript tests.
• API documentation.
• CircleCI jobs/workflows.
• Plugin is exported.

Additional Notes

• paired on this with @rochdev

[github-actions]

Overall package size

Self size: 2.78 MB
Deduped: 30.06 MB
No deduping: 30.26 MB

Dependency sizes

name	version	self size	total size
@datadog/pprof	1.0.2	8.74 MB	14.46 MB
@datadog/native-metrics	1.4.3	6.57 MB	6.58 MB
@datadog/native-appsec	1.2.1	5.1 MB	5.43 MB
opentracing	0.14.7	194.81 kB	194.81 kB
@datadog/sketches-js	2.1.0	109.9 kB	109.9 kB
lodash.sortby	4.7.0	75.76 kB	75.76 kB
lru-cache	7.14.0	74.95 kB	74.95 kB
semver	5.7.1	61.58 kB	61.58 kB
ipaddr.js	2.0.1	59.52 kB	59.52 kB
ignore	5.2.0	48.87 kB	48.87 kB
import-in-the-middle	1.3.3	31.42 kB	35.89 kB
istanbul-lib-coverage	3.2.0	29.34 kB	29.34 kB
retry	0.10.1	27.44 kB	27.44 kB
lodash.uniq	4.5.0	25.01 kB	25.01 kB
limiter	1.1.5	23.17 kB	23.17 kB
lodash.kebabcase	4.1.1	17.75 kB	17.75 kB
lodash.pick	4.4.0	16.33 kB	16.33 kB
crypto-randomuuid	1.0.0	11.18 kB	11.18 kB
diagnostics_channel	1.1.0	7.07 kB	7.07 kB
path-to-regexp	0.1.7	6.78 kB	6.78 kB
koalas	1.0.2	6.47 kB	6.47 kB
methods	1.1.2	5.29 kB	5.29 kB
module-details-from-path	1.0.3	4.47 kB	4.47 kB

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[codecov]

Codecov Report

Merging #2386 (485b08e) into master (96d0c90) will increase coverage by 0.90%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2386      +/-   ##
==========================================
+ Coverage   92.37%   93.28%   +0.90%     
==========================================
  Files         133      239     +106     
  Lines        5376     9376    +4000     
==========================================
+ Hits         4966     8746    +3780     
- Misses        410      630     +220     

Impacted Files	Coverage Δ
packages/dd-trace/src/opentracing/span.js	73.25% <0.00%> (-3.58%)	⬇️
...ges/datadog-plugin-graphql/src/tools/transforms.js	78.72% <0.00%> (ø)
packages/datadog-plugin-redis/src/index.js	95.34% <0.00%> (ø)
packages/datadog-plugin-moleculer/src/server.js	100.00% <0.00%> (ø)
...ages/datadog-instrumentations/src/elasticsearch.js	88.63% <0.00%> (ø)
packages/datadog-plugin-oracledb/src/index.js	94.28% <0.00%> (ø)
packages/datadog-plugin-dns/src/index.js	100.00% <0.00%> (ø)
packages/datadog-plugin-http2/src/index.js	100.00% <0.00%> (ø)
packages/datadog-plugin-net/src/index.js	100.00% <0.00%> (ø)
...s/datadog-instrumentations/src/moleculer/client.js	87.50% <0.00%> (ø)
... and 97 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Qard]

This increments and decrements in the same place as unfinished spans. How is this different? 🤔

[rochdev]

This increments and decrements in the same place as unfinished spans. How is this different?

The unfinished spans are tracking spans that are in memory, so they get decremented by the finalization registry as well when garbage collected.