allow next('route') and next('router') in router plugin #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2621 +/- ##
==========================================
+ Coverage 88.96% 89.12% +0.16%
==========================================
Files 296 296
Lines 10295 10355 +60
Branches 33 33
==========================================
+ Hits 9159 9229 +70
+ Misses 1136 1126 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Qard
previously approved these changes
Dec 16, 2022
Previously these were being treated as errors, when in fact these are normal in Router. Fixes #2607
bengl
force-pushed
the
bengl/router-next-route
branch
from
0f87184
to
308881e
Compare
Qard
approved these changes
Dec 19, 2022
rochdev
requested changes
Dec 19, 2022
rochdev
approved these changes
Dec 22, 2022
Qard
pushed a commit
that referenced
this pull request
Dec 22, 2022
Previously these were being treated as errors, when in fact these are normal in Router. Fixes #2607
Qard
pushed a commit
that referenced
this pull request
Dec 22, 2022
Previously these were being treated as errors, when in fact these are normal in Router. Fixes #2607
Qard
pushed a commit
that referenced
this pull request
Dec 23, 2022
Previously these were being treated as errors, when in fact these are normal in Router. Fixes #2607
juan-fernandez
pushed a commit
that referenced
this pull request
Jan 3, 2023
Previously these were being treated as errors, when in fact these are normal in Router. Fixes #2607
juan-fernandez
pushed a commit
that referenced
this pull request
Jan 4, 2023
Previously these were being treated as errors, when in fact these are normal in Router. Fixes #2607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these were being treated as errors, when in fact these are normal in Router.
Fixes #2607
What does this PR do?