Revert "Use the existing context if any to start the web spans (#1647)" #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c55168.
astuyve
approved these changes
Dec 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #2626 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 298 298
Lines 10381 10381
Branches 33 33
=======================================
Hits 9240 9240
Misses 1141 1141
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Qard
added a commit
that referenced
this pull request
Dec 22, 2022
Qard
added a commit
that referenced
this pull request
Dec 22, 2022
Qard
added a commit
that referenced
this pull request
Dec 23, 2022
juan-fernandez
pushed a commit
that referenced
this pull request
Jan 3, 2023
juan-fernandez
pushed a commit
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit 6c55168.
Motivation
The change was originally made to get AWS Lambda to connect web framework traces to an outer lambda span. The change however turns out to be unnecessary and caused issues for the tracer due to inheriting the active context if bootstrap code started a trace before starting the http server. This code is actually unreachable on Lambda so it should just be removed.