-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove query string from resource.name by default #2631
Conversation
Queries may contain private data so should not be included in resource.name by default, but with the queryInResourceName configuration it can be optionally enabled.
Codecov Report
@@ Coverage Diff @@
## master #2631 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 298 298
Lines 10381 10381
Branches 33 33
=======================================
Hits 9240 9240
Misses 1141 1141
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Queries may contain private data so should not be included in resource.name by default, but with the queryInResourceName configuration it can be optionally enabled.
Queries may contain private data so should not be included in resource.name by default, but with the queryInResourceName configuration it can be optionally enabled.
Queries may contain private data so should not be included in resource.name by default, but with the queryInResourceName configuration it can be optionally enabled.
Queries may contain private data so should not be included in resource.name by default, but with the queryInResourceName configuration it can be optionally enabled.
Queries may contain private data so should not be included in resource.name by default, but with the queryInResourceName configuration it can be optionally enabled.
@Qard So, in the This would just be And in the trace view as well? Woof. There should be an option for this, but I think we're going way overboard in catering to the rare folk who do have an issue. This greatly degrades the default behavior of the product, if I'm understanding this right. |
No, this does not impact HTTP route names, this is specifically for mongodb queries. Previously it produced span resource names something like |
What does this PR do?
This removes the query string from
resource.name
by default, allowing it to be restored with an additional config.Motivation
Queries may contain private data so should not be included in resource.name by default, but with the
queryInResourceName
configuration it can be optionally restored.Plugin Checklist
Fixes #2536
Fixes #2622