Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove no-longer-used version script #2645

Closed
wants to merge 1 commit into from
Closed

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented Dec 30, 2022

No description provided.

@bengl bengl requested a review from a team as a code owner December 30, 2022 18:49
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #2645 (e357c03) into master (744285f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2645   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files         301      301           
  Lines       10446    10446           
  Branches       33       33           
=======================================
  Hits         9368     9368           
  Misses       1078     1078           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Dec 30, 2022

Benchmarks

Comparing candidate commit e357c03 in PR branch bengl/rm-scripts-version with baseline commit 744285f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 966 cases.

@tlhunter
Copy link
Member

Pretty sure I landed this change in a different PR. Certainly there's no more version.js file in scripts.

@tlhunter tlhunter closed this Dec 20, 2023
@tlhunter tlhunter deleted the bengl/rm-scripts-version branch December 20, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants