Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Test skipping logic for cypress #3167

Merged
merged 8 commits into from
Jun 1, 2023

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented May 17, 2023

What does this PR do?

Add ITR logic to cypress.

Motivation

Allow cypress users to use ITR.

@github-actions
Copy link

github-actions bot commented May 17, 2023

Overall package size

Self size: 4.19 MB
Deduped: 58.39 MB
No deduping: 58.43 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #3167 (6786b87) into master (15b2767) will increase coverage by 1.16%.
The diff coverage is 72.91%.

@@            Coverage Diff             @@
##           master    #3167      +/-   ##
==========================================
+ Coverage   86.54%   87.71%   +1.16%     
==========================================
  Files         333      247      -86     
  Lines       11895     9141    -2754     
  Branches       33       33              
==========================================
- Hits        10295     8018    -2277     
+ Misses       1600     1123     -477     
Impacted Files Coverage Δ
packages/datadog-plugin-cypress/src/plugin.js 77.69% <72.72%> (-4.55%) ⬇️
...ty/intelligent-test-runner/get-skippable-suites.js 72.41% <75.00%> (-1.67%) ⬇️

... and 95 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented May 17, 2023

Benchmarks

Comparing candidate commit 6786b87 in PR branch juan-fernandez/add-itr-to-cypress with baseline commit 15b2767 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 444 metrics, 28 unstable metrics.

@juan-fernandez juan-fernandez force-pushed the juan-fernandez/add-itr-to-cypress branch from 8e234ac to 34ecedc Compare May 23, 2023 09:02
@juan-fernandez juan-fernandez changed the title [ci-visibility] [do not merge] [wip] Test skipping logic for cypress [ci-visibility] Test skipping logic for cypress May 23, 2023
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/add-itr-to-cypress branch from a448176 to bf428e3 Compare May 23, 2023 12:34
@juan-fernandez juan-fernandez marked this pull request as ready for review May 25, 2023 07:26
@juan-fernandez juan-fernandez requested a review from a team as a code owner May 25, 2023 07:26
package.json Outdated
"test:integration:cucumber": "mocha --colors --timeout 30000 \"integration-tests/cucumber/*.spec.js\"",
"test:integration:cypress": "mocha --colors --timeout 30000 \"integration-tests/cypress/*.spec.js\"",
"test:integration:playwright": "mocha --colors --timeout 30000 \"integration-tests/playwright/*.spec.js\"",
"test:integration:cucumber": "mocha --colors --timeout 30000 --exit \"integration-tests/cucumber/*.spec.js\"",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Needing this means the test isn't exiting properly and Mocha needs to kill it. Not only is this working around the issue, it won't be compatible with tap.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah there was some kind of weird race condition where if the test ended before the cypress process was finished, a handle was kept alive, not allowing the process to finish. I can't explain it but this change seems to fix it

@juan-fernandez juan-fernandez merged commit 40740ae into master Jun 1, 2023
103 of 104 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/add-itr-to-cypress branch June 1, 2023 07:46
This was referenced Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants