Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More beautiful debug logs #3171

Merged
merged 3 commits into from
May 22, 2023
Merged

Conversation

juan-fernandez
Copy link
Collaborator

What does this PR do?

By passing the space argument to JSON.stringify we make the debug logs easier to read.

Motivation

Easier debugging

@github-actions
Copy link

github-actions bot commented May 18, 2023

Overall package size

Self size: 4.15 MB
Deduped: 58.28 MB
No deduping: 58.33 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.1.0 13.31 MB 13.32 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #3171 (a987981) into master (7646468) will increase coverage by 0.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #3171      +/-   ##
==========================================
+ Coverage   86.65%   86.67%   +0.01%     
==========================================
  Files         327      328       +1     
  Lines       11844    11846       +2     
  Branches       33       33              
==========================================
+ Hits        10264    10268       +4     
+ Misses       1580     1578       -2     
Impacted Files Coverage Δ
packages/dd-trace/src/exporters/common/util.js 33.33% <33.33%> (ø)
packages/dd-trace/src/exporters/common/writer.js 90.00% <66.66%> (+0.52%) ⬆️
...-visibility/exporters/agentless/coverage-writer.js 86.95% <100.00%> (+7.78%) ⬆️
...ce/src/ci-visibility/exporters/agentless/writer.js 87.50% <100.00%> (+7.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@juan-fernandez juan-fernandez marked this pull request as ready for review May 18, 2023 10:25
@juan-fernandez juan-fernandez requested a review from a team as a code owner May 18, 2023 10:25
@pr-commenter
Copy link

pr-commenter bot commented May 18, 2023

Benchmarks

Comparing candidate commit fcffcf2 in PR branch juan-fernandez/better-debug-logs with baseline commit 3428a1f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 445 metrics, 27 unstable metrics.

@juan-fernandez juan-fernandez merged commit d349639 into master May 22, 2023
95 of 96 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/better-debug-logs branch May 22, 2023 10:11
thedavl pushed a commit that referenced this pull request May 30, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
This was referenced Jun 2, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants