-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make HTTP clients fit in the plugin hierarchy #3178
Conversation
Overall package sizeSelf size: 4.18 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
b58b131
to
41fce29
Compare
Codecov Report
@@ Coverage Diff @@
## master #3178 +/- ##
==========================================
- Coverage 86.57% 86.56% -0.01%
==========================================
Files 333 333
Lines 11934 11928 -6
Branches 33 33
==========================================
- Hits 10332 10326 -6
Misses 1602 1602
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1d03fe3
to
8ab1379
Compare
8ab1379
to
cfae42e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. It makes sense that an HTTP client would extend from ClientPlugin, being a client and all.
This appears to be entirely a refactor, nothing new, and the untouched tests all pass.
That said I would like @rochdev to take a quick look.
}) | ||
} | ||
|
||
connect (url) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keep it there? If there are no publishers, this doesn't impact anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure of the impact of subscribing to a channel, so I removed it by default. I'll revert this so we have an easy way to grab connect events in every client.
cfae42e
to
cac2cd6
Compare
* move http client to clientPlugin * move http2 client to clientPlugin
* move http client to clientPlugin * move http2 client to clientPlugin
* move http client to clientPlugin * move http2 client to clientPlugin
* move http client to clientPlugin * move http2 client to clientPlugin
* move http client to clientPlugin * move http2 client to clientPlugin
* move http client to clientPlugin * move http2 client to clientPlugin
What does this PR do?
ClientPlugin
connect
channels in allOutboundPlugin
s, since only cassandra actually uses this channelMotivation
To introduce peer service (see #3177), it's helpful for all client/producer plugins to have at least OutboundPlugin in their inheritance path.
Plugin Checklist
Additional Notes