Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Fix playwright@1.30.0 #3180

Merged
merged 4 commits into from
May 24, 2023

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented May 23, 2023

What does this PR do?

Fixes the version range support in playwright. Ignoring 1.30.0 was an oversight.

Motivation

Fixes #3176

Additional notes

Manually tested. Adding a test case specifically for 1.30.0 seems arbitrary, as there are other versions that could've been missed by this mistake.

@github-actions
Copy link

github-actions bot commented May 23, 2023

Overall package size

Self size: 4.17 MB
Deduped: 58.37 MB
No deduping: 58.41 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #3180 (95af98b) into master (15b2767) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
- Coverage   86.54%   86.54%   -0.01%     
==========================================
  Files         333      333              
  Lines       11895    11907      +12     
  Branches       33       33              
==========================================
+ Hits        10295    10305      +10     
- Misses       1600     1602       +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented May 23, 2023

Benchmarks

Comparing candidate commit 95af98b in PR branch juan-fernandez/fix-playwright-support with baseline commit 15b2767 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 446 metrics, 26 unstable metrics.

@juan-fernandez juan-fernandez marked this pull request as ready for review May 24, 2023 07:24
@juan-fernandez juan-fernandez requested a review from a team as a code owner May 24, 2023 07:24
@juan-fernandez juan-fernandez merged commit 42d6354 into master May 24, 2023
103 of 104 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-playwright-support branch May 24, 2023 07:49
thedavl pushed a commit that referenced this pull request May 30, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 1, 2023
This was referenced Jun 1, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
uurien pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when running Playwright test (this.rootDir undefined?)
2 participants