Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for node 16 in preparation for v5 release #3905

Merged
merged 32 commits into from
Jan 3, 2024

Conversation

khanayan123
Copy link
Collaborator

@khanayan123 khanayan123 commented Dec 27, 2023

What does this PR do?

drops support for node 16

Motivation

v5 release of the tracer

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8344baf) 84.70% compared to head (b57ae28) 84.55%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3905      +/-   ##
==========================================
- Coverage   84.70%   84.55%   -0.15%     
==========================================
  Files         237      235       -2     
  Lines       10147     9972     -175     
  Branches       33       33              
==========================================
- Hits         8595     8432     -163     
+ Misses       1552     1540      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 27, 2023

Benchmarks

Benchmark execution time: 2024-01-03 14:50:45

Comparing candidate commit b57ae28 in PR branch khanayan123/drop-node-16 with baseline commit 8344baf in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics.

Copy link

github-actions bot commented Dec 27, 2023

Overall package size

Self size: 5.82 MB
Deduped: 61.24 MB
No deduping: 62 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 6.0.0 14.48 MB 14.48 MB
@datadog/pprof 4.1.0 9.36 MB 10.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@khanayan123 khanayan123 force-pushed the khanayan123/drop-node-16 branch 3 times, most recently from 4f72ce6 to 341efbe Compare December 28, 2023 15:17
@khanayan123 khanayan123 marked this pull request as ready for review December 28, 2023 15:36
@khanayan123 khanayan123 requested review from a team as code owners December 28, 2023 15:36
.github/workflows/appsec.yml Show resolved Hide resolved
.github/workflows/plugins.yml Outdated Show resolved Hide resolved
.github/workflows/project.yml Outdated Show resolved Hide resolved
rochdev
rochdev previously approved these changes Dec 28, 2023
@rochdev rochdev added dont-land-on-v3.x If a commit depends on a major change not included in v3.x dont-land-on-v4.x If a commit depends on a major change not included in v4.x labels Dec 28, 2023
rochdev
rochdev previously approved these changes Jan 1, 2024
Qard
Qard previously approved these changes Jan 2, 2024
Copy link
Collaborator

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small suggestion.

.github/workflows/plugins.yml Show resolved Hide resolved
@khanayan123 khanayan123 dismissed stale reviews from Qard and rochdev via 9c7f7f6 January 2, 2024 14:29
Copy link
Contributor

@szegedi szegedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 from profiling

@DarcyRaynerDD
Copy link
Contributor

From a Serverless perspective, we are locked into supporting node 16 until at least June 2024. This is similar to what happened with node 14 support, where we were locked to using the v3 releases. Are we just dropping support because node 16 is no longer LTS?
https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
Is this

@khanayan123
Copy link
Collaborator Author

From a Serverless perspective, we are locked into supporting node 16 until at least June 2024. This is similar to what happened with node 14 support, where we were locked to using the v3 releases. Are we just dropping support because node 16 is no longer LTS? https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html Is this

Yes, ideally this release was supposed to happen a few months ago when Node 16 was officially no longer LTS

Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to not block the v5 release, everything looks good on the Serverless side, but we'd be pinned to the v4 line until August 2024 – date where AWS will drop support for Node 16 AWS Lambdas.

@khanayan123 khanayan123 merged commit f4d3218 into master Jan 3, 2024
120 of 218 checks passed
@khanayan123 khanayan123 deleted the khanayan123/drop-node-16 branch January 3, 2024 18:45
This was referenced Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-land-on-v3.x If a commit depends on a major change not included in v3.x dont-land-on-v4.x If a commit depends on a major change not included in v4.x semver-major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants