Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ts errors #3912

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Fix ts errors #3912

merged 3 commits into from
Jan 3, 2024

Conversation

Qard
Copy link
Collaborator

@Qard Qard commented Jan 2, 2024

Fixes #2693
Fixes #2787

What does this PR do?

Takes #2693 and fixes remaining TypeScript errors. I've also included the minor docs change in #2787.

Motivation

There's lots of TypeScript users. We should better support them.

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@Qard Qard added bug Something isn't working semver-patch labels Jan 2, 2024
@Qard Qard requested a review from a team as a code owner January 2, 2024 11:35
Copy link

github-actions bot commented Jan 2, 2024

Overall package size

Self size: 5.82 MB
Deduped: 61.24 MB
No deduping: 62 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 6.0.0 14.48 MB 14.48 MB
@datadog/pprof 4.1.0 9.36 MB 10.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bb99d1) 84.70% compared to head (3abdfe9) 84.70%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3912   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files         237      237           
  Lines       10147    10147           
  Branches       33       33           
=======================================
  Hits         8595     8595           
  Misses       1552     1552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 2, 2024

Benchmarks

Benchmark execution time: 2024-01-03 07:48:33

Comparing candidate commit 3abdfe9 in PR branch fix-ts-errors with baseline commit 7bb99d1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 521 metrics, 11 unstable metrics.

index.d.ts Outdated Show resolved Hide resolved
If options are not specified (and therefore if `options.orphanable !== false`) then `span` and the `done` callback are guaranteed to be set
docs/test.ts Show resolved Hide resolved
tlhunter
tlhunter previously approved these changes Jan 2, 2024
@khanayan123 khanayan123 mentioned this pull request Jan 2, 2024
simon-id
simon-id previously approved these changes Jan 3, 2024
@Qard Qard merged commit 8344baf into master Jan 3, 2024
111 checks passed
@Qard Qard deleted the fix-ts-errors branch January 3, 2024 12:53
@Qard Qard added dont-land-on-v3.x If a commit depends on a major change not included in v3.x dont-land-on-v4.x If a commit depends on a major change not included in v4.x labels Jan 3, 2024
This was referenced Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dont-land-on-v3.x If a commit depends on a major change not included in v3.x dont-land-on-v4.x If a commit depends on a major change not included in v4.x semver-major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants