Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lodash #3999

Merged
merged 1 commit into from
Jan 25, 2024
Merged

remove lodash #3999

merged 1 commit into from
Jan 25, 2024

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented Jan 25, 2024

What does this PR do?

Remove lodash

Motivation

In an effort to reduce our dependencies, especially for trivial functions.

Additional Notes

  • lodash.sortby is omitted for now, since it's a little harder to remove.

Copy link

github-actions bot commented Jan 25, 2024

Overall package size

Self size: 5.89 MB
Deduped: 61.54 MB
No deduping: 62.3 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (758ed65) 84.92% compared to head (ba53630) 69.19%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3999       +/-   ##
===========================================
- Coverage   84.92%   69.19%   -15.74%     
===========================================
  Files         239        1      -238     
  Lines       10257      198    -10059     
  Branches       33       33               
===========================================
- Hits         8711      137     -8574     
+ Misses       1546       61     -1485     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bengl bengl marked this pull request as ready for review January 25, 2024 15:37
@bengl bengl requested review from a team as code owners January 25, 2024 15:37
@bengl bengl requested a review from jbertran January 25, 2024 15:37
rochdev
rochdev previously approved these changes Jan 25, 2024
const result = {}
props.forEach(prop => {
if (prop in object) {
result[prop] = object[prop]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also takes from the prototype chain no ? unlike the "non-lodash pick" in the graphql file

@pr-commenter
Copy link

pr-commenter bot commented Jan 25, 2024

Benchmarks

Benchmark execution time: 2024-01-25 16:01:15

Comparing candidate commit ba53630 in PR branch bengl/remove-lodash with baseline commit 758ed65 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-136.444MB; -85.524MB] or [-14.390%; -9.020%]

@rochdev rochdev merged commit 2800692 into master Jan 25, 2024
106 checks passed
@rochdev rochdev deleted the bengl/remove-lodash branch January 25, 2024 16:34
rochdev pushed a commit that referenced this pull request Jan 25, 2024
rochdev pushed a commit that referenced this pull request Jan 25, 2024
rochdev pushed a commit that referenced this pull request Jan 25, 2024
rochdev pushed a commit that referenced this pull request Jan 25, 2024
rochdev pushed a commit that referenced this pull request Jan 25, 2024
rochdev pushed a commit that referenced this pull request Jan 25, 2024
@uttampatel04
Copy link

image
Getting lodash.pick high vulnerbility as it's dependent on other package.

How to fix it

@simon-id
Copy link
Member

simon-id commented May 3, 2024

@uttampatel04 sorry but we don't have lodash.pick in our dependency tree anymore. If you have it installed, it must be because of a different package than ours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants