-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove lodash #3999
remove lodash #3999
Conversation
Overall package sizeSelf size: 5.89 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3999 +/- ##
===========================================
- Coverage 84.92% 69.19% -15.74%
===========================================
Files 239 1 -238
Lines 10257 198 -10059
Branches 33 33
===========================================
- Hits 8711 137 -8574
+ Misses 1546 61 -1485 ☔ View full report in Codecov by Sentry. |
650b465
to
afd2863
Compare
afd2863
to
77c8c06
Compare
packages/utils/pick.js
Outdated
const result = {} | ||
props.forEach(prop => { | ||
if (prop in object) { | ||
result[prop] = object[prop] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also takes from the prototype chain no ? unlike the "non-lodash pick" in the graphql file
77c8c06
to
ba53630
Compare
BenchmarksBenchmark execution time: 2024-01-25 16:01:15 Comparing candidate commit ba53630 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
@uttampatel04 sorry but we don't have |
What does this PR do?
Remove lodash
Motivation
In an effort to reduce our dependencies, especially for trivial functions.
Additional Notes
lodash.sortby
is omitted for now, since it's a little harder to remove.