Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix span types for http servers and clients #470

Merged
merged 2 commits into from Feb 28, 2019
Merged

fix span types for http servers and clients #470

merged 2 commits into from Feb 28, 2019

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Feb 28, 2019

This PR fixes span types that were reversed for HTTP servers and clients.

@rochdev rochdev added bug Something isn't working integrations labels Feb 28, 2019
brettlangdon
brettlangdon approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're a web span....

@rochdev rochdev merged commit 944cfb8 into master Feb 28, 2019
@rochdev rochdev deleted the fix-span-types branch February 28, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rochdev @brettlangdon