Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for node 12 #554

Merged
merged 5 commits into from
May 1, 2019
Merged

add support for node 12 #554

merged 5 commits into from
May 1, 2019

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented May 1, 2019

This PR adds support for Node 12 by making the following changes:

  • Update usage of any deprecated APIs in v8 for native addons
  • Update node-abi to the latest version which contains the ABI version for Node 12
  • Add Node 12 tests to CI

@rochdev rochdev added bug Something isn't working core enhancement New feature or request labels May 1, 2019
@rochdev rochdev added this to the 0.11.1 milestone May 1, 2019
@rochdev rochdev requested a review from brettlangdon May 1, 2019 15:25
@rochdev rochdev merged commit 6b26a65 into master May 1, 2019
@rochdev rochdev deleted the node-12 branch May 1, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants