fix incompatibility with express-async-errors #555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an incompatibility with
express-async-errors
. The module defines a getter/setter onLayer.prototype.handle
where it wraps the layer handler when it gets set. The problem is that we overwrite the handler in theexpress
instrumentation, but after it's already been wrapped by the module. This means that we wrap their wrapper, and then reassignlayer.handle
which causes the setter to wrap our wrapper. This end up with a situation where we then haveasyncWrapper -> ddWrapper -> asyncWrapper -> handler
which results in unexpected behaviors.Since
express-async-errors
adds a__handle
property to the layer, we can patch that instead without triggering the setter.The behavior is different depending on the version of Node and in some cases internal to Express, so I was unable to write a proper unit test for this.
Fixes #548