mysql pooled queries have the wrong parent #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
approved these changes
Jun 11, 2019
rochdev
requested changes
Jun 11, 2019
|
I've fixed the build for |
rochdev
reviewed
Jun 12, 2019
I would add that test to the PR so that we catch any regression in |
|
I've added that test in the |
rochdev
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems some changes in the mysql instrumentation seem to have broken finding the parent, in recent versions of the mysql package.
Singalfx have also spotted it in this PR signalfx/signalfx-nodejs-tracing#12