Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add couchbase plugin #632

Merged
merged 21 commits into from
Aug 30, 2019
Merged

Add couchbase plugin #632

merged 21 commits into from
Aug 30, 2019

Conversation

rishabh
Copy link
Contributor

@rishabh rishabh commented Jul 19, 2019

What does this PR do?

Add the couchbase integration.

Plugin Checklist

Additional Notes

Work in progress, I need to fix cbas (analytics) queries. View queries also don't work for some reason.

I'm using https://github.com/rishabh/server-sandbox/ as the test image.

@rishabh rishabh requested a review from a team as a code owner July 19, 2019 15:20
@rishabh
Copy link
Contributor Author

rishabh commented Jul 22, 2019

Tests are failing because the full-text search service availability isn't sent to the SDK when it first connects to the cluster. This appears to be a bug in couchbase since you actually can execute a search query just fine through the web ui and the REST api. It takes at least 10 minutes before the availability is actually sent.

Relevant forum post: https://forums.couchbase.com/t/fts-service-for-couchbase-takes-a-long-time-to-show-up-in-cluster-configuration/22298

@rishabh
Copy link
Contributor Author

rishabh commented Jul 30, 2019

I haven't had any traction on that forum post I made so I'm going recommend disabling the test for Search queries for now. Please try running the Couchbase server for at least 15 to 20 minutes before running the Search query tests, otherwise they will fail with the error message Operation not supported.

packages/datadog-plugin-couchbase/src/index.js Outdated Show resolved Hide resolved
packages/datadog-plugin-couchbase/src/index.js Outdated Show resolved Hide resolved
packages/datadog-plugin-couchbase/test/index.spec.js Outdated Show resolved Hide resolved
packages/datadog-plugin-couchbase/src/index.js Outdated Show resolved Hide resolved
packages/datadog-plugin-couchbase/src/index.js Outdated Show resolved Hide resolved
packages/datadog-plugin-couchbase/src/index.js Outdated Show resolved Hide resolved
packages/datadog-plugin-couchbase/src/index.js Outdated Show resolved Hide resolved
packages/datadog-plugin-couchbase/src/index.js Outdated Show resolved Hide resolved
packages/datadog-plugin-couchbase/src/index.js Outdated Show resolved Hide resolved
@rishabh
Copy link
Contributor Author

rishabh commented Aug 23, 2019

I'm hitting some compiler errors when compiling libcouchbase, which might be the reason why I can't get the tests to run for both 2.4.0 and >=2.4.0. I'll investigate further.

@codecov-io

This comment has been minimized.

1 similar comment
@codecov-io

This comment has been minimized.

@rochdev rochdev added this to the 0.15.0 milestone Aug 28, 2019
@rishabh rishabh merged commit 77a3564 into master Aug 30, 2019
@rishabh rishabh deleted the rish/add-couchbase-plugin branch August 30, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants