Support circular references in tags and better array formatting #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rochdev
requested changes
Aug 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
==========================================
+ Coverage 96.22% 96.23% +<.01%
==========================================
Files 94 94
Lines 3234 3240 +6
==========================================
+ Hits 3112 3118 +6
Misses 122 122
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
==========================================
+ Coverage 96.22% 96.23% +<.01%
==========================================
Files 94 94
Lines 3234 3240 +6
==========================================
+ Hits 3112 3118 +6
Misses 122 122
Continue to review full report at Codecov.
|
rochdev
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes depth when it comes to tags and instead detects circular references. This will allow us to get infinite visibility for objects-as-tags.
This PR also changes the way we format arrays. We now leverage
JSON.stringifyto nest arrays rather than flattening them.Motivation
We want to ensure we can always get meaningful information from tags while at the same time ensuring readability.
Additional Notes
Please check the tests to see what the expected behaviour is, thanks!