fix incorrect type definitions for app analytics #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
force-pushed
the
fix-analytics-types
branch
from
da28480
to
f0ab8b6
Compare
brettlangdon
approved these changes
Sep 16, 2019
rochdev
added a commit
that referenced
this pull request
Sep 18, 2019
* fix incorrect type definitions for app analytics * fix analytics config available on non-instrumentation plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix incorrect type definitions for App Analytics.
Motivation
Reported in #674
Additional Notes
For now I fixed the type, but we should reintroduce this functionality officially later on.