Skip to content

Commit

Permalink
Remove libexecinfo on Alpine
Browse files Browse the repository at this point in the history
Fix GH-1824.

The quick summary is Alpine 3.17 removed this library, and on older
versions it's apparently not great quality anyway.
  • Loading branch information
morrisonlevi committed Dec 19, 2022
1 parent 2a6254b commit 623c5f9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1532,6 +1532,10 @@ jobs:
- run:
name: Build extension
command: |
# Backtraces on Alpine are apparently sketchy, and removed in Alpine 3.17:
# https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/36722
# Ensure libexecinfo is _not_ installed, so support isn't detected
apk remove libexecinfo
build-dd-trace-php
mv extensions extensions_$(uname -m)
- persist_to_workspace:
Expand Down
1 change: 0 additions & 1 deletion datadog-setup.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ function install($options)
// Checking required libraries
check_library_prerequisite_or_exit('libcurl');
if (is_alpine()) {
check_library_prerequisite_or_exit('libexecinfo');
if (is_truthy($options[OPT_ENABLE_PROFILING])) {
check_library_prerequisite_or_exit('libgcc_s');
}
Expand Down

0 comments on commit 623c5f9

Please sign in to comment.