Merge pull request #37 from localheinz/fix/assertion

Fix: Use more appropriate assertions
DataDog · Jul 25, 2018 · c6946eb · c6946eb
2 parents 384e48f + 17f6449
commit c6946eb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tests/Integration/Transport/HttpTest.php b/tests/Integration/Transport/HttpTest.php
@@ -97,6 +97,6 @@ public function testSilentlySendTraces()
         $httpTransport->send($traces);
         $output = ob_get_clean();
 
-        $this->assertEmpty($output);
+        $this->assertSame('', $output);
     }
 }
diff --git a/tests/Unit/Encoders/JsonTest.php b/tests/Unit/Encoders/JsonTest.php
@@ -34,7 +34,7 @@ public function testEncodeTracesSuccess()
 
         $jsonEncoder = new Json($logger->reveal());
         $encodedTrace = $jsonEncoder->encodeTraces([[$span]]);
-        $this->assertEquals($expectedPayload, $encodedTrace);
+        $this->assertJsonStringEqualsJsonString($expectedPayload, $encodedTrace);
     }
 
     public function testEncodeIgnoreSpanWhenEncodingFails()