-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with composer installing symfony/polyfill #19
Comments
chuck
added a commit
that referenced
this issue
Jul 11, 2018
https://github.com/symfony/polyfill notes that "When using Composer to manage your dependencies, you should not require the symfony/polyfill package, but the standalone ones"; also see #19
AFAIR we only required so we could include dd-trace-php/src/DDTrace/Span.php Line 240 in 8826319
|
Looks like just specifying symfony/polyfill-php70 instead of symfony/polyfill should also work, and is what the library wants us to do. |
Should be set, please let me know if you have any additional problems here! |
I've pushed 0.1.2 with all of the recent fixes, including one for this.
Thanks for the report!
…On Sun, Jul 29, 2018 at 1:32 AM Connor Clark ***@***.***> wrote:
With an empty composer file and no lock file, I get this error:
> composer require datadog/dd-trace
Using version ^0.1.0 for datadog/dd-trace
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Removal request for opentracing/opentracing == 1.0.0.0-beta5
- datadog/dd-trace 0.1.0 requires opentracing/opentracing 1.0.0-beta5 -> satisfiable by opentracing/opentracing[1.0.0-beta5].
- Installation request for datadog/dd-trace ^0.1.0 -> satisfiable by datadog/dd-trace[0.1.0].
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADN7vCoZMbMK37QSAgXsCiJkttJu05Mks5uLUjzgaJpZM4UmgOp>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For projects which already use a library dependent on some component of the
symfony/polyfill
library thecomposer require
process for this library will likely fail, e.g.This is likely why the
symfony/polyfill
project recommend:I've installed the library on a system with PHP 7.0.30 and the tests pass fine. So I think it's only a few specific polyfills that might be required and it would be worth listing them.
I can submit a PR to remove the polyfill library but obviously my case isn't the only one. Is there a list of extensions required that we can polyfill specifically for?
The text was updated successfully, but these errors were encountered: