Improves readme. #10
Improves readme. #10
Conversation
|
|
||
| ### Run tests | ||
| - PHP 5.6 or later |
There was a problem hiding this comment.
Miss bcmath extension. I know this is still wip but that way I don't forget :)
| @@ -18,7 +18,6 @@ | |||
| "minimum-stability": "dev", | |||
| "require": { | |||
| "php": "^5.6||^7.0", | |||
| "ext-bcmath": "*", | |||
There was a problem hiding this comment.
@kevinlebrun removed the dependency.
palazzem
added
☠️ do-not-merge/WIP
🍏 core
palazzem
added
cat:docs
and removed
🍏 core
README.md
Outdated
| 'global_tags' => ['host' => 'hostname'], | ||
| ]; | ||
|
|
||
| $tracer = new Tracer($transport, [ |
There was a problem hiding this comment.
general design: can't we provide reasonable defaults to avoid all this configuration? it's quite long to configure the tracer. If it already has defaults, let's create an advanced section with this snippet and a simple "Getting Started" where you initialize the tracer with defaults + trace a code-block
There was a problem hiding this comment.
The tracer comes with all this defaults, the reason why I included it in the example was to show all accepted arguments in the config. We can definitively move them to a advanced config or simply add a link in the bottom to the actual code (which also includes information).
| /** | ||
| * Enabled, when false, returns a no-op implementation of the Tracer. | ||
| */ | ||
| 'enabled' => true, |
There was a problem hiding this comment.
I removed this as it was not being used and can not find how is it being used in other libraries. cc @palazzem
jcchavezs
force-pushed
the
updates_readme
branch
from
c6d4a2a
to
c4a3782
Compare
jcchavezs
force-pushed
the
updates_readme
branch
from
c4a3782
to
7332068
Compare
No description provided.