Defer loading of PDO, Memcached, Slim, WordPress, and Yii integrations until first usage #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I confirmed in a debugger that this is a use-after-free that is fixed in PHP 7.0+. However, I'm not fully certain about _why_ it happens now, and didn't before; that seems to be due to another bug somewhere.
morrisonlevi
force-pushed
the
labbati/defer-integrations
branch
from
6a3c25f
to
e036056
Compare
Remove un-necessary YiiIntegrationLoader class Use non-tracing API in Yii integration Sort integrations in integrations.c
Remove un-necessary singleton Use non-tracing hook
morrisonlevi
changed the title
Remove elasticsearch.h as it no longer is large enough to merit its own file; likewise test_integration.h.
morrisonlevi
force-pushed
the
labbati/defer-integrations
branch
from
bb302e3
to
cb540f7
Compare
5 tasks
|
@SammyK you might want to take a look at it since both @morrisonlevi and I pushed to this branch? |
3 tasks
SammyK
pushed a commit
that referenced
this pull request
Oct 14, 2020
Defer loading of PDO, Memcached, Slim, WordPress, and Yii integrations until first usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR defers the loading of PDO, Memcached, Slim, WordPress, and Yii integrations until they are used.
Cleans up Yii2 and WordPress a tiny bit:
Readiness checklist
Reviewer checklist