add missing dependency on curl extension for PHP 8 #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyK
approved these changes
Feb 5, 2021
SammyK
added a commit
that referenced
this pull request
Mar 16, 2021
This error can occur when the curl extension is not loaded (either not compiled with PHP or compiled as a shared lib). The fix also allows us to remove curl as a required module to load ddtrace which was introduced in #1144.
5 tasks
SammyK
added a commit
that referenced
this pull request
Mar 17, 2021
This error can occur when the curl extension is not loaded (either not compiled with PHP or compiled as a shared lib). The fix also allows us to remove curl as a required module to load ddtrace which was introduced in #1144.
SammyK
added a commit
that referenced
this pull request
Mar 18, 2021
This error can occur when the curl extension is not loaded (either not compiled with PHP or compiled as a shared lib). The fix also allows us to remove curl as a required module to load ddtrace which was introduced in #1144.
SammyK
added a commit
that referenced
this pull request
Mar 26, 2021
* Fix "undefined symbol: curl_multi_ce" on PHP 8 This error can occur when the curl extension is not loaded (either not compiled with PHP or compiled as a shared lib). The fix also allows us to remove curl as a required module to load ddtrace which was introduced in #1144. * Update 8.0 and master buster containers * Add tests and update fix * Skip lang tests that fail the object ID diff * Remove valgrind_config copy pasta * Update docker-compose.yml Co-authored-by: Luca Abbati <luca.abbati@datadoghq.com> Co-authored-by: Levi Morrison <levi.morrison@datadoghq.com> Co-authored-by: Luca Abbati <luca.abbati@datadoghq.com>
SammyK
added a commit
that referenced
this pull request
Apr 6, 2021
This error can occur when the curl extension is not loaded (either not compiled with PHP or compiled as a shared lib). The fix also allows us to remove curl as a required module to load ddtrace which was introduced in #1144.
SammyK
added a commit
that referenced
this pull request
Apr 7, 2021
This error can occur when the curl extension is not loaded (either not compiled with PHP or compiled as a shared lib). The fix also allows us to remove curl as a required module to load ddtrace which was introduced in #1144.
SammyK
added a commit
that referenced
this pull request
Apr 9, 2021
This error can occur when the curl extension is not loaded (either not compiled with PHP or compiled as a shared lib). The fix also allows us to remove curl as a required module to load ddtrace which was introduced in #1144.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without curl extension, extension load fails with "undefined symbol: curl_multi_ce" (PHP 8 only , build with --enable-rtld-now) so will segfault on standard build when curl extension is build shared and not loaded.
PHP 5 and 7 are not affected as this symbol is not used