Remove non php7 code from ext/php7 folder #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
added
the
c-extension
SammyK
previously approved these changes
Mar 1, 2021
Comment on lines
8
to
9
| TSRMLS_FETCH(); | ||
| php_log_err((char *)message TSRMLS_CC); |
There was a problem hiding this comment.
In another followup PR, we could remove the TSRMLS_* references for PHP 7 and PHP 8. Then this would become:
Suggested change
| TSRMLS_FETCH(); | |
| php_log_err((char *)message TSRMLS_CC); | |
| php_log_err((char *)message); |
There was a problem hiding this comment.
I am leaving this for a separate PR as I want to discuss this further.
labbati
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get rid of all non php7 code in
ext/php7Readiness checklist
[ ] (only for Members) Changelog has been added to the release document.[ ] Tests added for this feature/bug.Reviewer checklist