Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non php5 code from ext/php5 folder #1164

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Remove non php5 code from ext/php5 folder #1164

merged 2 commits into from
Mar 4, 2021

Conversation

labbati
Copy link
Member

@labbati labbati commented Mar 3, 2021 •
edited by SammyK

Description

Get rid of all non php5 code in ext/php5

Readiness checklist

  • [ ] (only for Members) Changelog has been added to the release document.
  • [ ] Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@labbati labbati added the c-extension Apply this label to issues and prs related to the C-extension label Mar 3, 2021
@labbati labbati added this to the 0.56.0 milestone Mar 3, 2021
@labbati labbati requested a review from SammyK March 3, 2021 14:35
SammyK
SammyK approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @labbati.

@labbati labbati merged commit 263b30a into master Mar 4, 2021
@labbati labbati deleted the labbati/no-if-phpversion5 branch March 4, 2021 08:52
@labbati
Copy link
Member Author

labbati commented Mar 4, 2021

Thank you @SammyK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyK SammyK SammyK approved these changes

Assignees
No one assigned
Labels
c-extension Apply this label to issues and prs related to the C-extension
Projects
None yet
Milestone
0.56.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@labbati @SammyK