Auto-flushing (PHP 5)

[SammyK]

Description

This is a followup PR to #819 to add auto-flushing to PHP 5. It uses the new PHP 5 ZAI method-call seam added in #1186 to flush and reset the tracer automatically from a sandboxed environment when the auto-flushing feature is enabled.

Readiness checklist

• (only for Members) Changelog has been added to the release document.
• Tests added for this feature/bug. (Uses existing tests that are now enabled on PHP 5.)

Reviewer checklist

• Appropriate labels assigned.
• Milestone is set.
• Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

[morrisonlevi]

I think you possibly rebased this on master, instead of the newly rebased sammyk/zend-abstract-interface branch, which is why it's showing 5 commits and conflicts, I think?

[SammyK]

I haven't rebased this one yet. I will rebase once #1186 is merged (due to squashed commits).

[morrisonlevi]

Just one question on the finer semantics of zai_call_static_method_without_args.

[morrisonlevi]

PR looks good to me. I just have one directional question:

I think we may want/need to abstract zvals at some point so when we are writing integrations we can program against the ZAI and it works on all PHP versions. We don't want to write each integration for each PHP version; we want to write it once, like we would in .php code.

Do you think it's important to handle this sooner or later?

[SammyK]

I think we may want/need to abstract zvals at some point so when we are writing integrations we can program against the ZAI and it works on all PHP versions.

Indeed. This is certainly on the wishlist.

Do you think it's important to handle this sooner or later?

I think that depends on the integration API design. I think there might be a way we can write the integration API such that it can still interact with native Zend Engine data structures in an abstract, version-agnostic way. If that's the case, we can hold off on creating the ZAI data structure shims for a bit longer.

At any rate, we'll certainly have to cross that bridge when we design the ZAI integration API.

Thanks for the code review and the thoughts @morrisonlevi!